lkml.org 
[lkml]   [2021]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 64/68] EDAC/synopsys: Fix wrong value type assignment for edac_mode
    Date
    From: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>

    commit 5297cfa6bdf93e3889f78f9b482e2a595a376083 upstream.

    dimm->edac_mode contains values of type enum edac_type - not the
    corresponding capability flags. Fix that.

    Issue caught by Coverity check "enumerated type mixed with another
    type."

    [ bp: Rewrite commit message, add tags. ]

    Fixes: ae9b56e3996d ("EDAC, synps: Add EDAC support for zynq ddr ecc controller")
    Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
    Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
    Signed-off-by: Borislav Petkov <bp@suse.de>
    Cc: <stable@vger.kernel.org>
    Link: https://lkml.kernel.org/r/20210818072315.15149-1-shubhrajyoti.datta@xilinx.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/edac/synopsys_edac.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/edac/synopsys_edac.c
    +++ b/drivers/edac/synopsys_edac.c
    @@ -782,7 +782,7 @@ static void init_csrows(struct mem_ctl_i

    for (j = 0; j < csi->nr_channels; j++) {
    dimm = csi->channels[j]->dimm;
    - dimm->edac_mode = EDAC_FLAG_SECDED;
    + dimm->edac_mode = EDAC_SECDED;
    dimm->mtype = p_data->get_mtype(priv->baseaddr);
    dimm->nr_pages = (size >> PAGE_SHIFT) / csi->nr_channels;
    dimm->grain = SYNPS_EDAC_ERR_GRAIN;

    \
     
     \ /
      Last update: 2021-09-27 19:07    [W:5.776 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site