Messages in this thread | | | Date | Mon, 27 Sep 2021 17:58:22 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] printk: avoid -Wsometimes-uninitialized warning |
| |
On Mon, 27 Sep 2021 20:32:12 +0200 Arnd Bergmann <arnd@kernel.org> wrote:
> On Mon, Sep 27, 2021 at 6:21 PM Steven Rostedt <rostedt@goodmis.org> wrote: > > > > On Mon, 27 Sep 2021 14:19:18 +0100 > > Chris Down <chris@chrisdown.name> wrote: > > > > > Having IS_ENABLED and then an #ifdef seems to hurt code readability to me. > > > > I agree. > > > > Would this be a better solution? > > Sounds good, I'll follow up with that version after the next round of randconfig > builds.
OK, but can you remove the extra line that's between the brace and the text. I should have deleted it in that patch.
-- Steve
| |