lkml.org 
[lkml]   [2021]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/8] iio: dac: ds4424: Make use of the helper function dev_err_probe()
    Date
    When possible use dev_err_probe help to properly deal with the
    PROBE_DEFER error, the benefit is that DEFER issue will be logged
    in the devices_deferred debugfs file.
    Using dev_err_probe() can reduce code size, and the error value
    gets printed.

    Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
    ---
    drivers/iio/dac/ds4424.c | 9 +++------
    1 file changed, 3 insertions(+), 6 deletions(-)

    diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
    index 79527fbc250a..5a5e967b0be4 100644
    --- a/drivers/iio/dac/ds4424.c
    +++ b/drivers/iio/dac/ds4424.c
    @@ -232,12 +232,9 @@ static int ds4424_probe(struct i2c_client *client,
    indio_dev->name = id->name;

    data->vcc_reg = devm_regulator_get(&client->dev, "vcc");
    - if (IS_ERR(data->vcc_reg)) {
    - dev_err(&client->dev,
    - "Failed to get vcc-supply regulator. err: %ld\n",
    - PTR_ERR(data->vcc_reg));
    - return PTR_ERR(data->vcc_reg);
    - }
    + if (IS_ERR(data->vcc_reg))
    + return dev_err_probe(&client->dev, PTR_ERR(data->vcc_reg),
    + "Failed to get vcc-supply regulator.\n");

    mutex_init(&data->lock);
    ret = regulator_enable(data->vcc_reg);
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-09-27 10:27    [W:5.352 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site