lkml.org 
[lkml]   [2021]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] smp: Wake ksoftirqd on PREEMPT_RT instead do_softirq().
On Fri, Sep 24, 2021 at 11:47:55AM +0200, Sebastian Andrzej Siewior wrote:
> + if (local_softirq_pending()) {
> +
> + if (!IS_ENABLED(CONFIG_PREEMPT_RT)) {
> + do_softirq();
> + } else {
> + struct task_struct *ksoftirqd = this_cpu_ksoftirqd();
> +
> + if (ksoftirqd && !task_is_running(ksoftirqd))
> + wake_up_process(ksoftirqd);
> + }
> + }

At a cosmetic level this looks pretty weird. Why the empty line inside
the indented block? Why the pointless negation instead of the obvious
more straightforward order?

\
 
 \ /
  Last update: 2021-09-25 12:32    [W:0.094 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site