lkml.org 
[lkml]   [2021]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 004/100] staging: rtl8192u: Fix bitwise vs logical operator in TranslateRxSignalStuff819xUsb()
    Date
    From: Nathan Chancellor <nathan@kernel.org>

    commit 099ec97ac92911abfb102bb5c68ed270fc12e0dd upstream.

    clang warns:

    drivers/staging/rtl8192u/r8192U_core.c:4268:20: warning: bitwise and of
    boolean expressions; did you mean logical and? [-Wbool-operation-and]
    bpacket_toself = bpacket_match_bssid &
    ^~~~~~~~~~~~~~~~~~~~~
    &&
    1 warning generated.

    Replace the bitwise AND with a logical one to clear up the warning, as
    that is clearly what was intended.

    Fixes: 8fc8598e61f6 ("Staging: Added Realtek rtl8192u driver to staging")
    Signed-off-by: Nathan Chancellor <nathan@kernel.org>
    Link: https://lore.kernel.org/r/20210814235625.1780033-1-nathan@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/staging/rtl8192u/r8192U_core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/staging/rtl8192u/r8192U_core.c
    +++ b/drivers/staging/rtl8192u/r8192U_core.c
    @@ -4265,7 +4265,7 @@ static void TranslateRxSignalStuff819xUs
    bpacket_match_bssid = (type != IEEE80211_FTYPE_CTL) &&
    (ether_addr_equal(priv->ieee80211->current_network.bssid, (fc & IEEE80211_FCTL_TODS) ? hdr->addr1 : (fc & IEEE80211_FCTL_FROMDS) ? hdr->addr2 : hdr->addr3))
    && (!pstats->bHwError) && (!pstats->bCRC) && (!pstats->bICV);
    - bpacket_toself = bpacket_match_bssid &
    + bpacket_toself = bpacket_match_bssid &&
    (ether_addr_equal(praddr, priv->ieee80211->dev->dev_addr));

    if (WLAN_FC_GET_FRAMETYPE(fc) == IEEE80211_STYPE_BEACON)

    \
     
     \ /
      Last update: 2021-09-24 15:01    [W:3.229 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site