Messages in this thread | | | From | "" <> | Subject | RE: [PATCH v1 09/20] x86/resctrl: Abstract and use supports_mba_mbps() | Date | Fri, 24 Sep 2021 06:23:41 +0000 |
| |
Hi James,
> To determine whether the mba_mbps option to resctrl should be supported, > resctrl tests the boot cpus' x86_vendor. > > This isn't portable, and needs abstracting behind a helper so this check can be > part of the filesystem code that moves to /fs/. > > Re-use the tests set_mba_sc() does to determine if the mba_sc is supported > on this system. An 'alloc_capable' test is added so that this property isn't > implied by 'linear'. > > Signed-off-by: James Morse <james.morse@arm.com> > --- > arch/x86/kernel/cpu/resctrl/rdtgroup.c | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c > b/arch/x86/kernel/cpu/resctrl/rdtgroup.c > index e321ea5de562..4388685548a0 100644 > --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c > +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c > @@ -1888,17 +1888,26 @@ void rdt_domain_reconfigure_cdp(struct > rdt_resource *r) } > > /* > - * Enable or disable the MBA software controller > - * which helps user specify bandwidth in MBps. > * MBA software controller is supported only if > * MBM is supported and MBA is in linear scale. > */ > +static bool supports_mba_mbps(void) > +{ > + struct rdt_resource *r = > +&rdt_resources_all[RDT_RESOURCE_MBA].r_resctrl; > + > + return (is_mbm_enabled() && > + r->alloc_capable && is_mba_linear()); } > + > +/* > + * Enable or disable the MBA software controller > + * which helps user specify bandwidth in MBps. > + */ > static int set_mba_sc(bool mba_sc) > { > struct rdt_resource *r = > &rdt_resources_all[RDT_RESOURCE_MBA].r_resctrl; > > - if (!is_mbm_enabled() || !is_mba_linear() || > - mba_sc == is_mba_sc(r)) > + if (!supports_mba_mbps() || mba_sc == is_mba_sc(r)) > return -EINVAL; > > r->membw.mba_sc = mba_sc; > @@ -2317,7 +2326,7 @@ static int rdt_parse_param(struct fs_context *fc, > struct fs_parameter *param) > ctx->enable_cdpl2 = true; > return 0; > case Opt_mba_mbps: > - if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) > + if (supports_mba_mbps()) > return -EINVAL; I think if(!supports_mba_mbps()) is correct, isn't it?
Thanks,
Shaopeng Tan > ctx->enable_mba_mbps = true; > return 0; > -- > 2.30.2
| |