Messages in this thread | | | Date | Thu, 23 Sep 2021 23:03:05 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] ACPI: APEI: Check NULL argument in exported symbol |
| |
On Thu, Sep 23, 2021 at 10:48:11PM +0200, Borislav Petkov wrote: > On Thu, Sep 23, 2021 at 12:56:10PM -0700, Vasyl Gomonovych wrote: > > Exported symbol apei_hest_parse is external API > > and should check pointer argument > > Why? > > All users pass a proper, non-NULL function pointer AFAICT.
Looking at this more, that apei_hest_parse() thng should be made static and the export dropped.
The last user was removed in
708b20003624 ("PCI/AER: Remove HEST/FIRMWARE_FIRST parsing for AER ownership")
You could mention it in the commit log.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |