Messages in this thread | | | Date | Thu, 23 Sep 2021 17:23:21 +0000 | From | Yazen Ghannam <> | Subject | Re: [PATCHv3 2/2] drm/amdgpu: Register MCE notifier for Aldebaran RAS |
| |
On Thu, Sep 23, 2021 at 11:30:55AM -0400, Joshi, Mukul wrote: ... > > > + return NOTIFY_DONE; > > > + > > > + /* > > > + * If it is correctable error, return. > > > + */ > > > + if (mce_is_correctable(m)) > > > + return NOTIFY_OK; > > > > Shouldn't this be "NOTIFY_DONE" if "don't care" about this error? > > The thinking is we want to stop calling further consumers since it's a correctable error in GPU UMC and we are not taking any action about the correctable errors.
Shouldn't the error still be reported to EDAC for decoding and counting? I think users want this.
But it looks to me that either NOTIFY_OK or NOTIFY_DONE will allow this, so it's not a big deal. Was this intended to be NOTIFY_STOP?
Thanks, Yazen
| |