lkml.org 
[lkml]   [2021]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv3 2/2] drm/amdgpu: Register MCE notifier for Aldebaran RAS
    On Thu, Sep 23, 2021 at 11:30:55AM -0400, Joshi, Mukul wrote:
    ...
    > > > + return NOTIFY_DONE;
    > > > +
    > > > + /*
    > > > + * If it is correctable error, return.
    > > > + */
    > > > + if (mce_is_correctable(m))
    > > > + return NOTIFY_OK;
    > >
    > > Shouldn't this be "NOTIFY_DONE" if "don't care" about this error?
    >
    > The thinking is we want to stop calling further consumers since it's a correctable error in GPU UMC and we are not taking any action about the correctable errors.

    Shouldn't the error still be reported to EDAC for decoding and counting? I
    think users want this.

    But it looks to me that either NOTIFY_OK or NOTIFY_DONE will allow this, so
    it's not a big deal. Was this intended to be NOTIFY_STOP?

    Thanks,
    Yazen

    \
     
     \ /
      Last update: 2021-09-23 19:26    [W:4.054 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site