Messages in this thread | | | Date | Thu, 23 Sep 2021 23:19:20 +0800 | From | Gao Xiang <> | Subject | Re: [PATCH] erofs: fix misbehavior of unsupported chunk format check |
| |
On Thu, Sep 23, 2021 at 11:09:25PM +0800, Chao Yu wrote: > On 2021/9/22 17:51, Gao Xiang wrote: > > Unsupported chunk format should be checked with > > "if (vi->chunkformat & ~EROFS_CHUNK_FORMAT_ALL)" > > > > Found when checking with 4k-byte blockmap (although currently mkfs > > That means for 4k-byte blockmap, chunkformat should be zero, right?
Yeah, correct. It's a regression of 4kb chunk blockmap..
> > > uses inode chunk indexes format by default.) > > > > Fixes: c5aa903a59db ("erofs: support reading chunk-based uncompressed files") > > Cc: Liu Bo <bo.liu@linux.alibaba.com> > > Cc: Chao Yu <chao@kernel.org> > > Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com> > > Reviewed-by: Chao Yu <chao@kernel.org>
Thanks!
Thanks, Gao Xiang
> > Thanks,
| |