Messages in this thread | | | Date | Thu, 23 Sep 2021 16:16:45 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v7 04/12] x86/cpufeatures: Add TDX Guest CPU feature |
| |
On Thu, Sep 23, 2021 at 07:10:00AM -0700, Kuppuswamy, Sathyanarayanan wrote: > Initially, tdx_early_init() was added between kasan_early_init() and > idt_setup_early_handler() in x86_64_start_kernel(). But I found that > we have requirement to parse command line params in future > changes to tdx_early_init() (not from the patches in this series). Since > command line pointer is getting initialized in copy_bootdata(), I want > move the tdx_early_init() call below it. Instead of moving the initialization > order in future, I thought to move it appropriate place in the initial > patch. Regarding IDT dependency, #VE handling will have a dependency on > it (so it is better to initialize it before tdx_early_init()).
Then in your next version, pls add a comment that goes like this:
/* * This call needs to be here because... * <insert reasons> */
So that it is clear that its placement is special.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |