Messages in this thread | | | Date | Thu, 23 Sep 2021 12:49:48 +0200 | From | Thomas Weißschuh <> | Subject | Re: [PATCH v2] backlight: propagate errors from get_brightness() |
| |
On 2021-09-23T10:48+0100, Lee Jones wrote: > On Tue, 07 Sep 2021, Thomas Weißschuh wrote: > > > backlight.h documents "struct backlight_ops->get_brightness()" to return > > a negative errno on failure. > > So far these errors have not been handled in the backlight core. > > This leads to negative values being exposed through sysfs although only > > positive values are documented to be reported. > > > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > > --- > > > > v1: https://lore.kernel.org/dri-devel/20210906215525.15418-1-linux@weissschuh.net/ > > > > v1 -> v2: > > * use dev_err() instead of dev_warn() (Daniel Thompson) > > * Finish logging format string with newline (Daniel Thompson) > > * Log errno via dedicated error pointer format (Daniel Thompson) > > > > drivers/video/backlight/backlight.c | 22 +++++++++++++++++----- > > 1 file changed, 17 insertions(+), 5 deletions(-) > > Applied, thanks.
Hi Lee,
thanks!
Also I'm sorry about my nagging before. I was not aware you were on vacation and saw you respond to other mails.
Thomas
| |