Messages in this thread | | | From | Guenter Roeck <> | Date | Thu, 23 Sep 2021 17:25:19 -0700 | Subject | Re: [PATCH] platform/chrome: cros-ec-typec: Cleanup use of check_features |
| |
On Thu, Sep 23, 2021 at 1:03 PM Prashant Malani <pmalani@chromium.org> wrote: > > cros_ec_check_features() now returns a boolean. Remove the double NOT > operator since it's not required anymore. > > No functional changes are expected with this patch. > > Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> --- > drivers/platform/chrome/cros_ec_typec.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c > index 262a891eded3..7b3afb6cda5d 100644 > --- a/drivers/platform/chrome/cros_ec_typec.c > +++ b/drivers/platform/chrome/cros_ec_typec.c > @@ -1116,9 +1116,8 @@ static int cros_typec_probe(struct platform_device *pdev) > } > > ec_dev = dev_get_drvdata(&typec->ec->ec->dev); > - typec->typec_cmd_supported = !!cros_ec_check_features(ec_dev, EC_FEATURE_TYPEC_CMD); > - typec->needs_mux_ack = !!cros_ec_check_features(ec_dev, > - EC_FEATURE_TYPEC_MUX_REQUIRE_AP_ACK); > + typec->typec_cmd_supported = cros_ec_check_features(ec_dev, EC_FEATURE_TYPEC_CMD); > + typec->needs_mux_ack = cros_ec_check_features(ec_dev, EC_FEATURE_TYPEC_MUX_REQUIRE_AP_ACK); > > ret = cros_typec_ec_command(typec, 0, EC_CMD_USB_PD_PORTS, NULL, 0, > &resp, sizeof(resp)); > -- > 2.33.0.685.g46640cef36-goog >
| |