Messages in this thread | | | Subject | Re: [PATCH] KVM: VMX: Check if bus lock vmexit was preempted | From | Paolo Bonzini <> | Date | Wed, 22 Sep 2021 14:40:45 +0200 |
| |
On 22/09/21 12:32, Xiaoyao Li wrote: >> > > EXIT_REASON.bus_lock_detected may or may not be set when exit reason == > EXIT_REASON_BUS_LOCK. Intel will update ISE or SDM to state it. > > Maybe we can do below in handle_bus_lock_vmexit handler: > > if (!to_vmx(vcpu)->exit_reason.bus_lock_detected) > to_vmx(vcpu)->exit_reason.bus_lock_detected = 1; > > But is manually changing the hardware reported value for software > purpose a good thing?
No. That said, Hao's patch is just making the code clearer; there's no behavioral change since the "if" will just redo the same assignments as handle_bus_lock_vmexit.
Paolo
| |