Messages in this thread | | | Date | Wed, 22 Sep 2021 23:39:26 +0000 | From | Fenghua Yu <> | Subject | Re: [PATCH 4/8] x86/traps: Demand-populate PASID MSR via #GP |
| |
Hi, Peter,
On Wed, Sep 22, 2021 at 11:07:22PM +0200, Peter Zijlstra wrote: > On Mon, Sep 20, 2021 at 07:23:45PM +0000, Fenghua Yu wrote: > > > > + if (user_mode(regs) && fixup_pasid_exception()) > > + goto exit; > > + > > if (static_cpu_has(X86_FEATURE_UMIP)) { > > if (user_mode(regs) && fixup_umip_exception(regs)) > > goto exit; > > So you're eating any random #GP that might or might not be PASID > related. And all that witout a comment... Enlighten?
I will add a comment here.
Thanks.
-Fenghua
| |