lkml.org 
[lkml]   [2021]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5.10 079/122] net: phylink: add suspend/resume support
    Hi!

    > > > Joakim Zhang reports that Wake-on-Lan with the stmmac ethernet driver broke
    > > > when moving the incorrect handling of mac link state out of mac_config().
    > > > This reason this breaks is because the stmmac's WoL is handled by the MAC
    > > > rather than the PHY, and phylink doesn't cater for that scenario.
    > > >
    > > > This patch adds the necessary phylink code to handle suspend/resume events
    > > > according to whether the MAC still needs a valid link or not. This is the
    > > > barest minimum for this support.
    > >
    > > This adds functions that end up being unused in 5.10. AFAICT we do not
    > > need this in 5.10.
    >
    > It needs to be backported to any kernel that also has
    > "net: stmmac: fix MAC not working when system resume back with WoL active"
    > backported to. From what I can tell, the fixes line in that commit
    > refers to a commit (46f69ded988d) in v5.7-rc1.
    >
    > If "net: stmmac: fix MAC not working when system resume back with WoL
    > active" is not being backported to 5.10, then there is no need to
    > backport this patch.

    Agreed.

    > As I'm not being copied on the stmmac commit, I've no idea which kernels
    > this patch should be backported to.

    AFAICT "net: stmmac: fix MAC not working when..." is not queued for
    5.10.68-rc1 or 5.14.7-rc1.

    Best regards,
    Pavel
    --
    DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
    HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2021-09-21 23:46    [W:4.066 / U:0.600 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site