Messages in this thread | | | From | Martin Blumenstingl <> | Date | Tue, 21 Sep 2021 21:28:06 +0200 | Subject | Re: [PATCHv2] regulator: pwm-regulator: Make use of the helper function dev_err_probe() |
| |
Hi Anand,
On Tue, Sep 21, 2021 at 9:21 PM Anand Moon <linux.amoon@gmail.com> wrote: [...] > > > - dev_err(&pdev->dev, "Failed to get PWM: %d\n", ret); > > > - return ret; > > > + return dev_err_probe(&pdev->dev, PTR_ERR(drvdata->pwm), > > > + "Failed to register regulator %s\n", > > The message here should still be similar to the original one since the > > actual problem is that we could not get a reference to the PWM > > controller. At this point we are not trying to register the > > pwm-regulator yet. > > > > Yep, Typo I mixed up the logs completely. > it should be "Failed to get PWM, deferring probe" I think it should only be "Failed to get PWM" only - without "deferring probe". If the PWM is missing in .dts (which is not valid but might happen for someone who's creating a new .dts) then the "deferring probe" part is not correct as the error code is not -EPROBE_DEFER (it may be -ENOENT instead - or similar).
Best regards, Martin
| |