Messages in this thread | | | Subject | Re: [PATCH] Update min() to min_t() | From | Philipp Hortmann <> | Date | Tue, 21 Sep 2021 21:11:25 +0200 |
| |
On 9/21/21 8:04 AM, Greg KH wrote: > On Tue, Sep 21, 2021 at 07:52:46AM +0200, Philipp Hortmann wrote: >> diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c >> index 2dc58766273a..d87deee3e26e 100644 >> --- a/drivers/usb/usb-skeleton.c >> +++ b/drivers/usb/usb-skeleton.c >> @@ -363,7 +363,7 @@ static ssize_t skel_write(struct file *file, const char *user_buffer, >> int retval = 0; >> struct urb *urb = NULL; >> char *buf = NULL; >> - size_t writesize = min(count, (size_t)MAX_TRANSFER); >> + size_t writesize = min_t(size_t, count, MAX_TRANSFER); >> >> dev = file->private_data; >> >> -- >> 2.25.1 >> > > Has anyone actually built this driver in a while? > > thanks, > > greg k-h > Hi,
I have build and loaded the driver. To me this seems OK.
dmesg from loading: usb_skeleton: loading out-of-tree module taints kernel. usb_skeleton: module verification failed: signature and/or required key missing - tainting kernel usbcore: registered new interface driver skeleton
dmesg from unloading: usbcore: deregistering interface driver skeleton
Used kernel 5.15.0-rc1+
Bye Philipp
| |