Messages in this thread | | | Subject | Re: [PATCH] x86/resctrl: Fix kfree() of the wrong type in domain_add_cpu() | From | Reinette Chatre <> | Date | Tue, 21 Sep 2021 12:04:14 -0700 |
| |
Hi James,
On 9/17/2021 9:59 AM, James Morse wrote: > Commit 792e0f6f789b ("x86/resctrl: Split struct rdt_domain") separated > the architecture specific and filesystem parts of the resctrl domain > structures. > > This left the error paths in domain_add_cpu() kfree()ing the memory > with the wrong type. > > This will cause a problem if someone adds a new member to struct > rdt_hw_domain meaining d_resctrl is no longer the first member.
meaining -> meaning
> > Fixes: 792e0f6f789b ("x86/resctrl: Split struct rdt_domain") > Signed-off-by: James Morse <james.morse@arm.com> > --- > arch/x86/kernel/cpu/resctrl/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c > index b5de5a6c115c..bb1c3f5f60c8 100644 > --- a/arch/x86/kernel/cpu/resctrl/core.c > +++ b/arch/x86/kernel/cpu/resctrl/core.c > @@ -527,14 +527,14 @@ static void domain_add_cpu(int cpu, struct rdt_resource *r) > rdt_domain_reconfigure_cdp(r); > > if (r->alloc_capable && domain_setup_ctrlval(r, d)) { > - kfree(d); > + kfree(hw_dom); > return; > } > > if (r->mon_capable && domain_setup_mon_state(r, d)) { > kfree(hw_dom->ctrl_val); > kfree(hw_dom->mbps_val); > - kfree(d); > + kfree(hw_dom); > return; > } > >
Thank you very much.
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
| |