Messages in this thread | | | Subject | Re: [PATCH V9 1/8] dt-bindings: spi: Add sc7280 support | From | Stephen Boyd <> | Date | Tue, 21 Sep 2021 11:11:15 -0700 |
| |
Quoting Rajesh Patil (2021-09-21 03:38:59) > Add compatible for sc7280 SoC. > > Signed-off-by: Rajesh Patil <rajpat@codeaurora.org> > Reviewed-by: Doug Anderson <dianders@chromium.org> > ---
One nit below
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml > index ef5698f..1c8b2ea 100644 > --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml > +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml > @@ -21,7 +21,10 @@ allOf: > properties: > compatible: > items: > - - const: qcom,sdm845-qspi > + - enum: > + - qcom,sdm845-qspi > + - qcom,sc7280-qspi
Would be nice to keep this alphabet sorted too.
> + > - const: qcom,qspi-v1 > > reg:
| |