Messages in this thread | | | Subject | Re: [PATCH] KVM: nVMX: fix comments of handle_vmon() | From | Paolo Bonzini <> | Date | Tue, 21 Sep 2021 19:50:01 +0200 |
| |
On 08/09/21 19:17, Yu Zhang wrote: > "VMXON pointer" is saved in vmx->nested.vmxon_ptr since > commit 3573e22cfeca ("KVM: nVMX: additional checks on > vmxon region"). Also, handle_vmptrld() & handle_vmclear() > now have logic to check the VMCS pointer against the VMXON > pointer. > > So just remove the obsolete comments of handle_vmon(). > > Signed-off-by: Yu Zhang <yu.c.zhang@linux.intel.com> > --- > arch/x86/kvm/vmx/nested.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c > index bc6327950657..90f34f12f883 100644 > --- a/arch/x86/kvm/vmx/nested.c > +++ b/arch/x86/kvm/vmx/nested.c > @@ -4862,14 +4862,7 @@ static int enter_vmx_operation(struct kvm_vcpu *vcpu) > return -ENOMEM; > } > > -/* > - * Emulate the VMXON instruction. > - * Currently, we just remember that VMX is active, and do not save or even > - * inspect the argument to VMXON (the so-called "VMXON pointer") because we > - * do not currently need to store anything in that guest-allocated memory > - * region. Consequently, VMCLEAR and VMPTRLD also do not verify that the their > - * argument is different from the VMXON pointer (which the spec says they do). > - */ > +/* Emulate the VMXON instruction. */ > static int handle_vmon(struct kvm_vcpu *vcpu) > { > int ret; >
Queued, thanks.
Paolo
| |