Messages in this thread | | | Date | Tue, 21 Sep 2021 14:23:15 +0530 | From | skakit@codeauro ... | Subject | Re: [PATCH] spmi: pmic-arb: Add sid and address to error messages |
| |
On 2021-09-21 05:18, Stephen Boyd wrote: > It's useful to know what particular device/component is having trouble > accessing the bus. Add the sid and address to error messages here so > that debugging is a little simpler. > > Cc: Subbaraman Narayanamurthy <subbaram@codeaurora.org> > Cc: satya priya <skakit@codeaurora.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > ---
Reviewed-by: Satya Priya <skakit@codeaurora.org>
> drivers/spmi/spmi-pmic-arb.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/drivers/spmi/spmi-pmic-arb.c > b/drivers/spmi/spmi-pmic-arb.c > index bbbd311eda03..e397c2532c8d 100644 > --- a/drivers/spmi/spmi-pmic-arb.c > +++ b/drivers/spmi/spmi-pmic-arb.c > @@ -261,20 +261,21 @@ static int pmic_arb_wait_for_done(struct > spmi_controller *ctrl, > > if (status & PMIC_ARB_STATUS_DONE) { > if (status & PMIC_ARB_STATUS_DENIED) { > - dev_err(&ctrl->dev, "%s: transaction denied (0x%x)\n", > - __func__, status); > + dev_err(&ctrl->dev, "%s: %#x %#x: transaction denied (%#x)\n", > + __func__, sid, addr, status); > return -EPERM; > } > > if (status & PMIC_ARB_STATUS_FAILURE) { > - dev_err(&ctrl->dev, "%s: transaction failed (0x%x)\n", > - __func__, status); > + dev_err(&ctrl->dev, "%s: %#x %#x: transaction failed (%#x)\n", > + __func__, sid, addr, status); > + WARN_ON(1); > return -EIO; > } > > if (status & PMIC_ARB_STATUS_DROPPED) { > - dev_err(&ctrl->dev, "%s: transaction dropped (0x%x)\n", > - __func__, status); > + dev_err(&ctrl->dev, "%s: %#x %#x: transaction dropped (%#x)\n", > + __func__, sid, addr, status); > return -EIO; > } > > @@ -283,8 +284,8 @@ static int pmic_arb_wait_for_done(struct > spmi_controller *ctrl, > udelay(1); > } > > - dev_err(&ctrl->dev, "%s: timeout, status 0x%x\n", > - __func__, status); > + dev_err(&ctrl->dev, "%s: %#x %#x: timeout, status %#x\n", > + __func__, sid, addr, status); > return -ETIMEDOUT; > }
| |