lkml.org 
[lkml]   [2021]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip: x86/core] x86: Increase exception stack sizes
    The following commit has been merged into the x86/core branch of tip:

    Commit-ID: 7d490a1fe5678d5c4abc2652a7dcfbc0b261add8
    Gitweb: https://git.kernel.org/tip/7d490a1fe5678d5c4abc2652a7dcfbc0b261add8
    Author: Peter Zijlstra <peterz@infradead.org>
    AuthorDate: Wed, 15 Sep 2021 16:19:46 +02:00
    Committer: Peter Zijlstra <peterz@infradead.org>
    CommitterDate: Sat, 18 Sep 2021 12:18:33 +02:00

    x86: Increase exception stack sizes

    It turns out that a single page of stack is trivial to overflow with
    all the tracing gunk enabled. Raise the exception stacks to 2 pages,
    which is still half the interrupt stacks, which are at 4 pages.

    Reported-by: Michael Wang <yun.wang@linux.alibaba.com>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Link: https://lkml.kernel.org/r/YUIO9Ye98S5Eb68w@hirez.programming.kicks-ass.net
    ---
    arch/x86/include/asm/page_64_types.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/x86/include/asm/page_64_types.h b/arch/x86/include/asm/page_64_types.h
    index a8d4ad8..e9e2c3b 100644
    --- a/arch/x86/include/asm/page_64_types.h
    +++ b/arch/x86/include/asm/page_64_types.h
    @@ -15,7 +15,7 @@
    #define THREAD_SIZE_ORDER (2 + KASAN_STACK_ORDER)
    #define THREAD_SIZE (PAGE_SIZE << THREAD_SIZE_ORDER)

    -#define EXCEPTION_STACK_ORDER (0 + KASAN_STACK_ORDER)
    +#define EXCEPTION_STACK_ORDER (1 + KASAN_STACK_ORDER)
    #define EXCEPTION_STKSZ (PAGE_SIZE << EXCEPTION_STACK_ORDER)

    #define IRQ_STACK_ORDER (2 + KASAN_STACK_ORDER)
    \
     
     \ /
      Last update: 2021-09-21 09:29    [W:3.944 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site