lkml.org 
[lkml]   [2021]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 007/175] cryptoloop: add a deprecation warning
    Date
    From: Christoph Hellwig <hch@lst.de>

    [ Upstream commit 222013f9ac30b9cec44301daa8dbd0aae38abffb ]

    Support for cryptoloop has been officially marked broken and deprecated
    in favor of dm-crypt (which supports the same broken algorithms if
    needed) in Linux 2.6.4 (released in March 2004), and support for it has
    been entirely removed from losetup in util-linux 2.23 (released in April
    2013). Add a warning and a deprecation schedule.

    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Link: https://lore.kernel.org/r/20210827163250.255325-1-hch@lst.de
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/block/Kconfig | 4 ++--
    drivers/block/cryptoloop.c | 2 ++
    2 files changed, 4 insertions(+), 2 deletions(-)

    diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
    index 894102fd5a06..b701c79f07e5 100644
    --- a/drivers/block/Kconfig
    +++ b/drivers/block/Kconfig
    @@ -257,7 +257,7 @@ config BLK_DEV_LOOP_MIN_COUNT
    dynamically allocated with the /dev/loop-control interface.

    config BLK_DEV_CRYPTOLOOP
    - tristate "Cryptoloop Support"
    + tristate "Cryptoloop Support (DEPRECATED)"
    select CRYPTO
    select CRYPTO_CBC
    depends on BLK_DEV_LOOP
    @@ -269,7 +269,7 @@ config BLK_DEV_CRYPTOLOOP
    WARNING: This device is not safe for journaled file systems like
    ext3 or Reiserfs. Please use the Device Mapper crypto module
    instead, which can be configured to be on-disk compatible with the
    - cryptoloop device.
    + cryptoloop device. cryptoloop support will be removed in Linux 5.16.

    source "drivers/block/drbd/Kconfig"

    diff --git a/drivers/block/cryptoloop.c b/drivers/block/cryptoloop.c
    index 3d31761c0ed0..adbfd3e2a60f 100644
    --- a/drivers/block/cryptoloop.c
    +++ b/drivers/block/cryptoloop.c
    @@ -203,6 +203,8 @@ init_cryptoloop(void)

    if (rc)
    printk(KERN_ERR "cryptoloop: loop_register_transfer failed\n");
    + else
    + pr_warn("the cryptoloop driver has been deprecated and will be removed in in Linux 5.16\n");
    return rc;
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-20 19:08    [W:4.386 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site