lkml.org 
[lkml]   [2021]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 061/175] Bluetooth: increase BTNAMSIZ to 21 chars to fix potential buffer overflow
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit 713baf3dae8f45dc8ada4ed2f5fdcbf94a5c274d ]

    An earlier commit replaced using batostr to using %pMR sprintf for the
    construction of session->name. Static analysis detected that this new
    method can use a total of 21 characters (including the trailing '\0')
    so we need to increase the BTNAMSIZ from 18 to 21 to fix potential
    buffer overflows.

    Addresses-Coverity: ("Out-of-bounds write")
    Fixes: fcb73338ed53 ("Bluetooth: Use %pMR in sprintf/seq_printf instead of batostr")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/bluetooth/cmtp/cmtp.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/bluetooth/cmtp/cmtp.h b/net/bluetooth/cmtp/cmtp.h
    index c32638dddbf9..f6b9dc4e408f 100644
    --- a/net/bluetooth/cmtp/cmtp.h
    +++ b/net/bluetooth/cmtp/cmtp.h
    @@ -26,7 +26,7 @@
    #include <linux/types.h>
    #include <net/bluetooth/bluetooth.h>

    -#define BTNAMSIZ 18
    +#define BTNAMSIZ 21

    /* CMTP ioctl defines */
    #define CMTPCONNADD _IOW('C', 200, int)
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-20 19:07    [W:2.407 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site