lkml.org 
[lkml]   [2021]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 034/175] PCI: Call Max Payload Size-related fixup quirks early
    Date
    From: Marek Behún <kabel@kernel.org>

    commit b8da302e2955fe4d41eb9d48199242674d77dbe0 upstream.

    pci_device_add() calls HEADER fixups after pci_configure_device(), which
    configures Max Payload Size.

    Convert MPS-related fixups to EARLY fixups so pci_configure_mps() takes
    them into account.

    Fixes: 27d868b5e6cfa ("PCI: Set MPS to match upstream bridge")
    Link: https://lore.kernel.org/r/20210624171418.27194-1-kabel@kernel.org
    Signed-off-by: Marek Behún <kabel@kernel.org>
    Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/pci/quirks.c | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    --- a/drivers/pci/quirks.c
    +++ b/drivers/pci/quirks.c
    @@ -2994,12 +2994,12 @@ static void fixup_mpss_256(struct pci_de
    {
    dev->pcie_mpss = 1; /* 256 bytes */
    }
    -DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SOLARFLARE,
    - PCI_DEVICE_ID_SOLARFLARE_SFC4000A_0, fixup_mpss_256);
    -DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SOLARFLARE,
    - PCI_DEVICE_ID_SOLARFLARE_SFC4000A_1, fixup_mpss_256);
    -DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SOLARFLARE,
    - PCI_DEVICE_ID_SOLARFLARE_SFC4000B, fixup_mpss_256);
    +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SOLARFLARE,
    + PCI_DEVICE_ID_SOLARFLARE_SFC4000A_0, fixup_mpss_256);
    +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SOLARFLARE,
    + PCI_DEVICE_ID_SOLARFLARE_SFC4000A_1, fixup_mpss_256);
    +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SOLARFLARE,
    + PCI_DEVICE_ID_SOLARFLARE_SFC4000B, fixup_mpss_256);

    /* Intel 5000 and 5100 Memory controllers have an errata with read completion
    * coalescing (which is enabled by default on some BIOSes) and MPS of 256B.

    \
     
     \ /
      Last update: 2021-09-20 18:59    [W:4.382 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site