lkml.org 
[lkml]   [2021]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/2] dt-bindings: snps,dw-apb-ssi: Use 'flash' node name instead of 'spi-flash' in example
    On Mon, Sep 20, 2021 at 07:57:13PM +0530, Apurva Nandan wrote:
    > Change the nodename in the example with spi-nand from 'spi-flash@1'
    > to 'flash@1' to make the schema uniform with both spi-nand and spi-nor
    > flashes. jedec,spi-nor.yaml uses 'flash@' nodename for spi-nor flashes,
    > so make the spi-nand examples in dt-bindings use it too for uniformity.
    >
    > Signed-off-by: Apurva Nandan <a-nandan@ti.com>
    > ---
    > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)

    Seems reasonable.
    Reviewed-by: Serge Semin <fancer.lancer@gmail.com>

    -Sergey

    >
    > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
    > index ca91201a9926..d7e08b03e204 100644
    > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
    > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
    > @@ -171,7 +171,7 @@ examples:
    > cs-gpios = <&gpio0 13 0>,
    > <&gpio0 14 0>;
    > rx-sample-delay-ns = <3>;
    > - spi-flash@1 {
    > + flash@1 {
    > compatible = "spi-nand";
    > reg = <1>;
    > rx-sample-delay-ns = <7>;
    > --
    > 2.25.1
    >

    \
     
     \ /
      Last update: 2021-09-20 16:45    [W:2.864 / U:1.600 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site