Messages in this thread | | | From | "NeilBrown" <> | Subject | Re: [PATCH 2/5] mm/vmscan: Throttle reclaim and compaction when too may pages are isolated | Date | Tue, 21 Sep 2021 09:27:56 +1000 |
| |
On Mon, 20 Sep 2021, Mel Gorman wrote: > @@ -2291,8 +2302,7 @@ shrink_inactive_list(unsigned long nr_to_scan, struct lruvec *lruvec, > return 0; > > /* wait a bit for the reclaimer. */ > - msleep(100); > - stalled = true; > + reclaim_throttle(pgdat, VMSCAN_THROTTLE_ISOLATED, HZ/10);
Why drop the assignment to "stalled"? Doing that changes the character of the loop - and makes the 'stalled' variable always 'false'.
NeilBrown
| |