lkml.org 
[lkml]   [2021]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 084/168] net: dsa: lantiq_gswip: Add 200ms assert delay
    Date
    From: Aleksander Jan Bajkowski <olek2@wp.pl>

    [ Upstream commit 111b64e35ea03d58c882832744f571a88bb2e2e2 ]

    The delay is especially needed by the xRX300 and xRX330 SoCs. Without
    this patch, some phys are sometimes not properly detected.

    The patch was tested on BT Home Hub 5A and D-Link DWR-966.

    Fixes: a09d042b0862 ("net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330")
    Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
    Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
    Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/dsa/lantiq_gswip.c | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
    index 64d6dfa83122..267324889dd6 100644
    --- a/drivers/net/dsa/lantiq_gswip.c
    +++ b/drivers/net/dsa/lantiq_gswip.c
    @@ -1885,6 +1885,12 @@ static int gswip_gphy_fw_load(struct gswip_priv *priv, struct gswip_gphy_fw *gph

    reset_control_assert(gphy_fw->reset);

    + /* The vendor BSP uses a 200ms delay after asserting the reset line.
    + * Without this some users are observing that the PHY is not coming up
    + * on the MDIO bus.
    + */
    + msleep(200);
    +
    ret = request_firmware(&fw, gphy_fw->fw_name, dev);
    if (ret) {
    dev_err(dev, "failed to load firmware: %s, error: %i\n",
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-20 20:46    [W:7.798 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site