lkml.org 
[lkml]   [2021]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 023/122] net/{mlx5|nfp|bnxt}: Remove unnecessary RTNL lock assert
    Date
    From: Eli Cohen <elic@nvidia.com>

    commit 7c3a0a018e672a9723a79b128227272562300055 upstream.

    Remove the assert from the callback priv lookup function since it does
    not require RTNL lock and is already protected by flow_indr_block_lock.

    This will avoid warnings from being emitted to dmesg if the driver
    registers its callback after an ingress qdisc was created for a
    netdevice.

    The warnings started after the following patch was merged:
    commit 74fc4f828769 ("net: Fix offloading indirect devices dependency on qdisc order creation")

    Signed-off-by: Eli Cohen <elic@nvidia.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 3 ---
    drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 3 ---
    drivers/net/ethernet/netronome/nfp/flower/offload.c | 3 ---
    3 files changed, 9 deletions(-)

    --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
    +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
    @@ -1870,9 +1870,6 @@ bnxt_tc_indr_block_cb_lookup(struct bnxt
    {
    struct bnxt_flower_indr_block_cb_priv *cb_priv;

    - /* All callback list access should be protected by RTNL. */
    - ASSERT_RTNL();
    -
    list_for_each_entry(cb_priv, &bp->tc_indr_block_list, list)
    if (cb_priv->tunnel_netdev == netdev)
    return cb_priv;
    --- a/drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c
    @@ -298,9 +298,6 @@ mlx5e_rep_indr_block_priv_lookup(struct
    {
    struct mlx5e_rep_indr_block_priv *cb_priv;

    - /* All callback list access should be protected by RTNL. */
    - ASSERT_RTNL();
    -
    list_for_each_entry(cb_priv,
    &rpriv->uplink_priv.tc_indr_block_priv_list,
    list)
    --- a/drivers/net/ethernet/netronome/nfp/flower/offload.c
    +++ b/drivers/net/ethernet/netronome/nfp/flower/offload.c
    @@ -1732,9 +1732,6 @@ nfp_flower_indr_block_cb_priv_lookup(str
    struct nfp_flower_indr_block_cb_priv *cb_priv;
    struct nfp_flower_priv *priv = app->priv;

    - /* All callback list access should be protected by RTNL. */
    - ASSERT_RTNL();
    -
    list_for_each_entry(cb_priv, &priv->indr_block_cb_priv, list)
    if (cb_priv->netdev == netdev)
    return cb_priv;

    \
     
     \ /
      Last update: 2021-09-20 20:37    [W:4.304 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site