lkml.org 
[lkml]   [2021]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 048/260] openrisc: dont printk() unconditionally
    Date
    From: Randy Dunlap <rdunlap@infradead.org>

    [ Upstream commit 946e1052cdcc7e585ee5d1e72528ca49fb295243 ]

    Don't call printk() when CONFIG_PRINTK is not set.
    Fixes the following build errors:

    or1k-linux-ld: arch/openrisc/kernel/entry.o: in function `_external_irq_handler':
    (.text+0x804): undefined reference to `printk'
    (.text+0x804): relocation truncated to fit: R_OR1K_INSN_REL_26 against undefined symbol `printk'

    Fixes: 9d02a4283e9c ("OpenRISC: Boot code")
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Reported-by: kernel test robot <lkp@intel.com>
    Cc: Jonas Bonn <jonas@southpole.se>
    Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
    Cc: Stafford Horne <shorne@gmail.com>
    Cc: openrisc@lists.librecores.org
    Signed-off-by: Stafford Horne <shorne@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/openrisc/kernel/entry.S | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/arch/openrisc/kernel/entry.S b/arch/openrisc/kernel/entry.S
    index c6481cfc5220..6b27cf4a0d78 100644
    --- a/arch/openrisc/kernel/entry.S
    +++ b/arch/openrisc/kernel/entry.S
    @@ -547,6 +547,7 @@ EXCEPTION_ENTRY(_external_irq_handler)
    l.bnf 1f // ext irq enabled, all ok.
    l.nop

    +#ifdef CONFIG_PRINTK
    l.addi r1,r1,-0x8
    l.movhi r3,hi(42f)
    l.ori r3,r3,lo(42f)
    @@ -560,6 +561,7 @@ EXCEPTION_ENTRY(_external_irq_handler)
    .string "\n\rESR interrupt bug: in _external_irq_handler (ESR %x)\n\r"
    .align 4
    .previous
    +#endif

    l.ori r4,r4,SPR_SR_IEE // fix the bug
    // l.sw PT_SR(r1),r4
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-20 20:10    [W:6.736 / U:1.764 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site