lkml.org 
[lkml]   [2021]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 291/293] qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    [ Upstream commit 9ddbc2a00d7f63fa9748f4278643193dac985f2d ]

    Previous commit 68233c583ab4 removes the qlcnic_rom_lock()
    in qlcnic_pinit_from_rom(), but remains its corresponding
    unlock function, which is odd. I'm not very sure whether the
    lock is missing, or the unlock is redundant. This bug is
    suggested by a static analysis tool, please advise.

    Fixes: 68233c583ab4 ("qlcnic: updated reset sequence")
    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c
    index c48a0e2d4d7e..6a009d51ec51 100644
    --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c
    +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c
    @@ -440,7 +440,6 @@ int qlcnic_pinit_from_rom(struct qlcnic_adapter *adapter)
    QLCWR32(adapter, QLCNIC_CRB_PEG_NET_4 + 0x3c, 1);
    msleep(20);

    - qlcnic_rom_unlock(adapter);
    /* big hammer don't reset CAM block on reset */
    QLCWR32(adapter, QLCNIC_ROMUSB_GLB_SW_RESET, 0xfeffffff);

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-09-20 20:07    [W:2.609 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site