lkml.org 
[lkml]   [2021]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 204/217] ibmvnic: check failover_pending in login response
    Date
    From: Sukadev Bhattiprolu <sukadev@linux.ibm.com>

    commit 273c29e944bda9a20a30c26cfc34c9a3f363280b upstream.

    If a failover occurs before a login response is received, the login
    response buffer maybe undefined. Check that there was no failover
    before accessing the login response buffer.

    Fixes: 032c5e82847a ("Driver for IBM System i/p VNIC protocol")
    Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/ibm/ibmvnic.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    --- a/drivers/net/ethernet/ibm/ibmvnic.c
    +++ b/drivers/net/ethernet/ibm/ibmvnic.c
    @@ -3965,6 +3965,14 @@ static int ibmvnic_probe(struct vio_dev
    goto ibmvnic_init_fail;
    } while (rc == EAGAIN);

    + if (adapter->failover_pending) {
    + adapter->init_done_rc = -EAGAIN;
    + netdev_dbg(netdev, "Failover pending, ignoring login response\n");
    + complete(&adapter->init_done);
    + /* login response buffer will be released on reset */
    + return 0;
    + }
    +
    netdev->mtu = adapter->req_mtu - ETH_HLEN;

    rc = device_create_file(&dev->dev, &dev_attr_failover);

    \
     
     \ /
      Last update: 2021-09-20 19:32    [W:4.096 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site