lkml.org 
[lkml]   [2021]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v10 0/6] Re-introduce TX FIFO resize for larger EP bursting
Date
Jack Pham wrote:
> Hi Thinh,
>
> On Sat, Aug 21, 2021 at 02:57:07AM +0000, Thinh Nguyen wrote:
>> I took a look at 24f779dac8f3 ("usb: gadget: f_uac2/u_audio: add
>> feedback endpoint support") that Ferry reported the issue from
>> bisection. I see at least a couple problems in the new UAC2 changes.
>>
>> 1) usb_ep_dequeue() is asynchronous. Don't free requests before the
>> controller driver give them back.
>>
>> 2) Did you test with SuperSpeed? I don't see companion descriptor.
>
> We caught this too when testing f_uac2 in SuperSpeed mode. I can
> prepare a patch.
>

Thanks for the test and the fix.

BR,
Thinh
\
 
 \ /
  Last update: 2021-09-03 00:59    [W:1.749 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site