Messages in this thread | | | From | Thinh Nguyen <> | Subject | Re: [PATCH v10 0/6] Re-introduce TX FIFO resize for larger EP bursting | Date | Thu, 2 Sep 2021 22:58:48 +0000 |
| |
Jack Pham wrote: > Hi Thinh, > > On Sat, Aug 21, 2021 at 02:57:07AM +0000, Thinh Nguyen wrote: >> I took a look at 24f779dac8f3 ("usb: gadget: f_uac2/u_audio: add >> feedback endpoint support") that Ferry reported the issue from >> bisection. I see at least a couple problems in the new UAC2 changes. >> >> 1) usb_ep_dequeue() is asynchronous. Don't free requests before the >> controller driver give them back. >> >> 2) Did you test with SuperSpeed? I don't see companion descriptor. > > We caught this too when testing f_uac2 in SuperSpeed mode. I can > prepare a patch. >
Thanks for the test and the fix.
BR, Thinh
| |