Messages in this thread | | | From | Linus Torvalds <> | Date | Thu, 2 Sep 2021 15:38:01 -0700 | Subject | Re: [GIT PULL] first round of SCSI updates for the 5.14+ merge window |
| |
On Thu, Sep 2, 2021 at 9:50 AM James Bottomley <James.Bottomley@hansenpartnership.com> wrote: > > We also picked up a non trivial conflict with the already upstream > block tree in st.c
Hmm. Resolving that conflict, I just reacted to how the st.c code passes in a NULL gendisk to scsi_ioctl() and then on to blk_execute_rq().
Just checking that was fine, and I notice how *many* places do that.
Should the blk_execute_rq() function even take that "struct gendisk *bd_disk" argument at all?
Maybe the right thing to do would be for the people who care to just set rq->rq_disk before starting the request..
But I guess it's traditional, and nobody cares.
Linus
| |