lkml.org 
[lkml]   [2021]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT PULL] first round of SCSI updates for the 5.14+ merge window
On Thu, Sep 2, 2021 at 9:50 AM James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
>
> We also picked up a non trivial conflict with the already upstream
> block tree in st.c

Hmm. Resolving that conflict, I just reacted to how the st.c code
passes in a NULL gendisk to scsi_ioctl() and then on to
blk_execute_rq().

Just checking that was fine, and I notice how *many* places do that.

Should the blk_execute_rq() function even take that "struct gendisk
*bd_disk" argument at all?

Maybe the right thing to do would be for the people who care to just
set rq->rq_disk before starting the request..

But I guess it's traditional, and nobody cares.

Linus

\
 
 \ /
  Last update: 2021-09-03 00:38    [W:0.050 / U:1.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site