Messages in this thread | | | Date | Thu, 2 Sep 2021 21:14:49 +0300 | Subject | Re: [PATCH] media: usb: fix memory leak in stk_camera_probe | From | Pavel Skripkin <> |
| |
On 9/2/21 14:22, Dongliang Mu wrote: > On Thu, Sep 2, 2021 at 7:15 PM Hans Verkuil <hverkuil@xs4all.nl> wrote: >> >> On 02/09/2021 13:10, Dongliang Mu wrote: >> > On Thu, Sep 2, 2021 at 6:59 PM Dongliang Mu <mudongliangabcd@gmail.com> wrote: >> >> >> >> On Thu, Sep 2, 2021 at 6:54 PM Mauro Carvalho Chehab <mchehab@kernel.org> wrote: >> >>> >> >>> Em Thu, 2 Sep 2021 12:39:37 +0200 >> >>> Greg KH <gregkh@linuxfoundation.org> escreveu: >> >>> >> >>>> On Thu, Sep 02, 2021 at 06:23:36PM +0800, Dongliang Mu wrote: >> >>>>> On Fri, Jul 23, 2021 at 6:11 PM Dongliang Mu <mudongliangabcd@gmail.com> wrote: >> >>>>>> >> >>>>>> On Wed, Jul 14, 2021 at 11:23 AM Dongliang Mu <mudongliangabcd@gmail.com> wrote: >> >>>>>>> >> >>>>>>> stk_camera_probe mistakenly execute usb_get_intf and increase the >> >>>>>>> refcount of interface->dev. >> >>>>>>> >> >>>>>>> Fix this by removing the execution of usb_get_intf. >> >>>>>> >> >>>>>> Any idea about this patch? >> >>>>> >> >>>>> +cc Dan Carpenter, gregkh >> >>>>> >> >>>>> There is no reply in this thread in one month. Can someone give some >> >>>>> feedback on this patch? >> >>>> >> >>>> This is the media developers domain, not much I can do here. >> >>> >> >>> There is a high volume of patches for the media subsystem. Anyway, >> >>> as your patch is at our patchwork instance: >> >>> >> >>> https://patchwork.linuxtv.org/project/linux-media/patch/20210714032340.504836-1-mudongliangabcd@gmail.com/ >> >>> >> >>> It should be properly tracked, and likely handled after the end of >> >>> the merge window. >> > >> > Hi Mauro, >> > >> > I found there is another fix [1] for the same memory leak from Pavel >> > Skripkin (already cc-ed in this thread). >> > >> > [1] https://www.spinics.net/lists/stable/msg479628.html >> >> Ah, that's why I marked it as Obsoleted :-) > > Oh, I see. If that patch is already merged, please remark my patch as Obsoleted. > > Curiously, I did not get an email notification to mark my patch as > Obsoleted before. Why? > >>
Hi, Dongliang!
Yep my patch has been merged already (1 month ago, I guess).
With regards, Pavel Skripkin
| |