Messages in this thread | | | Date | Thu, 2 Sep 2021 19:58:36 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/3] x86/amd_nb: Add support for HSMP mailbox access |
| |
On Thu, Sep 02, 2021 at 11:11:53PM +0530, Naveen Krishna Chatradhi wrote: > On Fam19h server CPUs from AMD an HSMP (Host System Management Port) > mailbox interface is added to monitor and manage the CPU parameters.
Mailbox? Hmm, that rings a bell. There's drivers/mailbox/ with a bunch of drivers in there. Those are
"Mailbox is a framework to control hardware communication between on-chip processors through queued messages and interrupt driven signals."
I wonder if that HSMP thing can be wrapped like a mailbox driver...
If not, I still don't like it being slapped in amd_nb.c where it would be built in on *all* AMD hardware which is kinda too much.
You could make it a separate driver module called amd_hsmp.ko which loads only on the appropriate hw and uses amd_nb.c for detection only like the other drivers, for example.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |