Messages in this thread | | | Date | Thu, 2 Sep 2021 10:35:55 -0700 | From | Pawan Gupta <> | Subject | Re: [v6 1/1] x86/bugs: Implement mitigation for Predictive Store |
| |
On 01.09.2021 15:35, Babu Moger wrote: > > >On 9/1/21 3:30 PM, Babu Moger wrote: >> Pawan, That is kind of odd. The ssb_mitigation enums are defined in bug.c. To be consistent it is better to keep it in nospec-branch.h as they are related. > >Sorry, I meant all these mitigations related enums are in nospec-branch.h.
Thats not true:
$ grep "^enum.*{$" arch/x86/kernel/cpu/bugs.c enum taa_mitigations { enum srbds_mitigations { enum spectre_v1_mitigation { enum spectre_v2_mitigation_cmd { enum spectre_v2_user_cmd { enum ssb_mitigation_cmd {
>So, it better to keep it there for consistency.
But, I am not too adamant about it.
Thanks, Pawan
| |