lkml.org 
[lkml]   [2021]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] media: uvcvideo: use dynamic allocation for uvc_copy_op
Hi Kyeongdon,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.14 next-20210902]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Kyeongdon-Kim/media-uvcvideo-use-dynamic-allocation-for-uvc_copy_op/20210902-172043
base: git://linuxtv.org/media_tree.git master
config: openrisc-buildonly-randconfig-r003-20210902 (attached as .config)
compiler: or1k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/2a36e010c8f73cd5c36072caf7e63431a07f4aad
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kyeongdon-Kim/media-uvcvideo-use-dynamic-allocation-for-uvc_copy_op/20210902-172043
git checkout 2a36e010c8f73cd5c36072caf7e63431a07f4aad
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/media/usb/uvc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

In file included from drivers/media/usb/uvc/uvc_video.c:25:
drivers/media/usb/uvc/uvc_video.c: In function 'uvc_free_urb_cop':
>> drivers/media/usb/uvc/uvc_video.c:1619:26: error: 'uvc_urb' undeclared (first use in this function)
1619 | for_each_uvc_urb(uvc_urb, stream) {
| ^~~~~~~
drivers/media/usb/uvc/uvcvideo.h:654:15: note: in definition of macro 'for_each_uvc_urb'
654 | for ((uvc_urb) = &(uvc_streaming)->uvc_urb[0]; \
| ^~~~~~~
drivers/media/usb/uvc/uvc_video.c:1619:26: note: each undeclared identifier is reported only once for each function it appears in
1619 | for_each_uvc_urb(uvc_urb, stream) {
| ^~~~~~~
drivers/media/usb/uvc/uvcvideo.h:654:15: note: in definition of macro 'for_each_uvc_urb'
654 | for ((uvc_urb) = &(uvc_streaming)->uvc_urb[0]; \
| ^~~~~~~
drivers/media/usb/uvc/uvc_video.c: In function 'uvc_alloc_urb_cop':
drivers/media/usb/uvc/uvc_video.c:1631:26: error: 'uvc_urb' undeclared (first use in this function)
1631 | for_each_uvc_urb(uvc_urb, stream) {
| ^~~~~~~
drivers/media/usb/uvc/uvcvideo.h:654:15: note: in definition of macro 'for_each_uvc_urb'
654 | for ((uvc_urb) = &(uvc_streaming)->uvc_urb[0]; \
| ^~~~~~~


vim +/uvc_urb +1619 drivers/media/usb/uvc/uvc_video.c

1616
1617 static void uvc_free_urb_cop(struct uvc_streaming *stream)
1618 {
> 1619 for_each_uvc_urb(uvc_urb, stream) {
1620 if (uvc_urb->copy_operations) {
1621 kfree(uvc_urb->copy_operations);
1622 uvc_urb->copy_operations = NULL;
1623 }
1624 }
1625 }
1626

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2021-09-02 19:31    [W:0.038 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site