Messages in this thread | | | From | Nick Desaulniers <> | Date | Thu, 2 Sep 2021 10:23:27 -0700 | Subject | Re: [PATCH 02/24] x86/traps: Move arch/x86/kernel/traps.c to arch/x86/entry/ |
| |
On Thu, Sep 2, 2021 at 10:19 AM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > On Thu, Sep 2, 2021 at 7:05 PM Nick Desaulniers <ndesaulniers@google.com> wrote: > > > > The above 2 hunks should go in include/linux/compiler_attributes.h, > > but yes. I'd been meaning to send such a patch; it's nice to have > > Note that `compiler_attributes.h` does not keep attributes that depend > on config options.
Sure, I'd drop the config check and define it conditionally on the __has_attribute check alone. Does it hurt to mark functions as __attribute__((no_stack_protector)) when we're not building with -fstack-protector*? Nope!
> On one hand, I feel we should put them there. On the other hand, I > want to avoid making a mess again since the purpose of the file is to > keep things clean for the majority of attributes. > > Perhaps we should do a middle-ground, and only allow those that depend > on a single config option, i.e. no nesting `#if`s or complex > conditions. -- Thanks, ~Nick Desaulniers
| |