Messages in this thread | | | Subject | Re: [PATCH v2] ASoC: Intel: boards: Fix CONFIG_SND_SOC_SDW_MOCKUP select | From | Pierre-Louis Bossart <> | Date | Thu, 2 Sep 2021 10:02:18 -0500 |
| |
On 8/2/21 4:24 PM, Nathan Chancellor wrote: > When CONFIG_SND_SOC_INTEL_SOUNDWIRE_SOF_MACH is enabled without > CONFIG_EXPERT, there is a Kconfig warning about unmet dependencies: > > WARNING: unmet direct dependencies detected for SND_SOC_SDW_MOCKUP > Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && > EXPERT [=n] && SOUNDWIRE [=y] > Selected by [y]: > - SND_SOC_INTEL_SOUNDWIRE_SOF_MACH [=y] && ... > > Selecting a symbol does not account for dependencies. There are three > ways to resolve this: > > 1. Make CONFIG_SND_SOC_INTEL_SOUNDWIRE_SOF_MACH select > CONFIG_SND_SOC_SDW_MOCKUP only if CONFIG_EXPERT is set. > > 2. Make CONFIG_SND_SOC_SDW_MOCKUP's prompt depend on CONFIG_EXPERT so > that it can be selected by options that only depend on > CONFIG_SOUNDWIRE but still appear as a prompt to the user when > CONFIG_EXPERT is set. > > 3. Make CONFIG_SND_SOC_INTEL_SOUNDWIRE_SOF_MACH imply > CONFIG_SND_SOC_SDW_MOCKUP, which will select > CONFIG_SND_SOC_SDW_MOCKUP when its dependencies are enabled but still > allow the user to disable it. > > Go with the third option as it gives the most flexibility while > retaining the original intent of the select. > > Fixes: 0ccac3bcf356 ("ASoC: Intel: boards: sof_sdw: add SoundWire mockup codecs for tests") > Suggested-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
This patch was missed, maybe because I didn't provide a formal ack on my own suggestion, so here goes:
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Mark, can you add it to 5.15 fixes please? Thank you. -Pierre
| |