Messages in this thread | | | Date | Thu, 2 Sep 2021 15:43:54 +0100 | From | Mark Brown <> | Subject | Re: [PATCH RESEND 1/2] ASoC: max98927: Handle reset gpio when probing i2c |
| |
On Mon, Aug 30, 2021 at 12:13:41AM +0200, Alejandro Tafalla wrote: > On Sun, Aug 29, 2021 at 11:22:35PM +0300, Andy Shevchenko wrote:
> > > + struct gpio_desc *reset_gpio;
> > Why? Are you using it outside of ->probe()?
> No, I'll delete it and use a local variable.
It can be good to reassert reset when unloading the driver in order to ensure that the device isn't active. It doesn't really matter though. [unhandled content-type:application/pgp-signature] | |