lkml.org 
[lkml]   [2021]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] perf build: Report fa ilure for testing feature libopencsd


On September 2, 2021 9:45:29 AM GMT-03:00, Leo Yan <leo.yan@linaro.org> wrote:
>On Thu, Sep 02, 2021 at 09:22:21AM -0300, Arnaldo Carvalho de Melo wrote:
>> Em Thu, Sep 02, 2021 at 04:18:00PM +0800, Leo Yan escreveu:
>> > When build perf tool with passing option 'CORESIGHT=1' explicitly, if
>> > the feature test fails for library libopencsd, the build doesn't
>> > complain the feature failure and continue to build the tool with
>> > disabling the CoreSight feature insteadly.
>> >
>> > This patch changes the building behaviour, when build perf tool with the
>> > option 'CORESIGHT=1' and detect the failure for testing feature
>> > libopencsd, the build process will be aborted and it shows the complaint
>> > info.
>>
>> Thanks, added some committer notes to show that it now works:
>>
>> commit 8fb36b1f54873870262810d3db10526559e1d6c2
>> Author: Leo Yan <leo.yan@linaro.org>
>> Date: Thu Sep 2 16:18:00 2021 +0800
>>
>> perf build: Report failure for testing feature libopencsd
>>
>> When build perf tool with passing option 'CORESIGHT=1' explicitly, if
>> the feature test fails for library libopencsd, the build doesn't
>> complain the feature failure and continue to build the tool with
>> disabling the CoreSight feature insteadly.
>>
>> This patch changes the building behaviour, when build perf tool with the
>> option 'CORESIGHT=1' and detect the failure for testing feature
>> libopencsd, the build process will be aborted and it shows the complaint
>> info.
>>
>> Committer testing:
>>
>> First make sure there is no opencsd library installed:
>>
>> $ rpm -qa | grep -i csd
>> $ sudo rm -rf `find /usr/local -name "*csd*"`
>> $ find /usr/local -name "*csd*"
>> $
>>
>> Then cleanup the perf build output directory:
>>
>> $ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ;
>> $
>>
>> And try to build explicitely asking for coresight:
>>
>> $ make O=/tmp/build/perf CORESIGHT=1 O=/tmp/build/perf -C tools/perf install-bin
>
>The build command contains duplicate 'O=/tmp/build/perf'.

Oops, I'll fix it, thanks.

- Arnaldo

\
 
 \ /
  Last update: 2021-09-02 15:01    [W:0.037 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site