Messages in this thread | | | Date | Thu, 2 Sep 2021 11:28:45 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v5 3/3] staging: r8188eu: incorrect type in assignment |
| |
On Sat, Aug 28, 2021 at 04:40:46PM +0530, Aakash Hemadri wrote: > Fix sparse warning: > > rtw_br_ext.c:516:57: warning: incorrect type in assignment > (different base types) > > rtw_br_ext.c:516:57: expected unsigned short > > rtw_br_ext.c:516:57: got restricted __be16 [usertype] > > *pMagic holds __be16 change it's type to __be16
I do not understand this sentence, what are you trying to say?
Remember, "it's" is short for "it is".
> Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com> > --- > drivers/staging/r8188eu/core/rtw_br_ext.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c > index 38f1bd591da9..bce73e8cbd52 100644 > --- a/drivers/staging/r8188eu/core/rtw_br_ext.c > +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c > @@ -474,7 +474,7 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method) > /* Handle PPPoE frame */ > /*---------------------------------------------------*/ > struct pppoe_hdr *ph = (struct pppoe_hdr *)(skb->data + ETH_HLEN); > - unsigned short *pMagic; > + __be16 *pMagic; > > switch (method) { > case NAT25_CHECK: > @@ -512,7 +512,7 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method) > tag->tag_len = htons(MAGIC_CODE_LEN+RTL_RELAY_TAG_LEN+old_tag_len); > > /* insert the magic_code+client mac in relay tag */ > - pMagic = (unsigned short *)tag->tag_data; > + pMagic = (__be16 *)tag->tag_data;
Is this whole function ever actually called?
Can someone run a ftrace on the driver to see if this function ever runs, and if not, remove it?
thanks,
greg k-h
| |