Messages in this thread | | | Date | Sun, 19 Sep 2021 07:51:17 -0400 | From | Alyssa Rosenzweig <> | Subject | Re: [PATCH v2 2/2] mailbox: apple: Add driver for Apple mailboxes |
| |
> +#define APPLE_ASC_MBOX_CONTROL_FULL BIT(16) > +#define APPLE_ASC_MBOX_CONTROL_EMPTY BIT(17) ... > +#define APPLE_M3_MBOX_CONTROL_FULL BIT(16) > +#define APPLE_M3_MBOX_CONTROL_EMPTY BIT(17)
It might make sense to combine these to just
> +#define APPLE_MBOX_CONTROL_FULL BIT(16) > +#define APPLE_MBOX_CONTROL_EMPTY BIT(17)
..unless we have a reason to think the status bits otherwise differ.
Regardless of that minor nit, this is
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
| |