lkml.org 
[lkml]   [2021]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] mailbox: apple: Add driver for Apple mailboxes
> +#define APPLE_ASC_MBOX_CONTROL_FULL  BIT(16)
> +#define APPLE_ASC_MBOX_CONTROL_EMPTY BIT(17)
...
> +#define APPLE_M3_MBOX_CONTROL_FULL BIT(16)
> +#define APPLE_M3_MBOX_CONTROL_EMPTY BIT(17)

It might make sense to combine these to just

> +#define APPLE_MBOX_CONTROL_FULL BIT(16)
> +#define APPLE_MBOX_CONTROL_EMPTY BIT(17)

..unless we have a reason to think the status bits otherwise differ.

Regardless of that minor nit, this is

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>

\
 
 \ /
  Last update: 2021-09-19 14:02    [W:0.215 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site