Messages in this thread | | | Date | Sat, 18 Sep 2021 19:32:31 +0200 | Subject | Re: staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed? | From | Michael Straube <> |
| |
On 9/18/21 18:46, Larry Finger wrote: > On 9/18/21 08:31, Michael Straube wrote: >> Hi Larry, Phillip and all. >> >> While removing code that checks for the chip type I stumbled upon this: >> >> >> void odm_DynamicTxPowerNIC(struct odm_dm_struct *pDM_Odm) >> { >> if (!(pDM_Odm->SupportAbility & ODM_BB_DYNAMIC_TXPWR)) >> return; >> >> if (pDM_Odm->SupportICType == ODM_RTL8188E) { >> /* ??? */ >> /* This part need to be redefined. */ >> } >> } >> >> >> (pDM_Odm->SupportICType == ODM_RTL8188E) is always true in this driver. >> Currently the function does nothing and the driver seems to work fine. >> Because of the comment I'm not sure if the whole function can just be >> removed? > > Yes, I agree. No later driver does anything with this routine, thus it > is dead and can be removed. > > Larry >
Ok, thank you.
Regards, Michael
| |