Messages in this thread | | | Date | Sat, 18 Sep 2021 13:18:23 +0200 | From | Greg KH <> | Subject | Re: [PATCH 1/2] pwm: Add different PWM output types support |
| |
On Fri, Sep 13, 2019 at 03:57:43PM -0700, Guru Das Srinagesh wrote: > From: Fenglin Wu <fenglinw@codeaurora.org> > > Normally, PWM channel has fixed output until software request to change > its settings. There are some PWM devices which their outputs could be > changed autonomously according to a predefined pattern programmed in > hardware. Add pwm_output_type enum type to identify these two different > PWM types and add relevant helper functions to set and get PWM output > types and pattern. > > Change-Id: Ia1f914a45ab4f4dd7be037a395eeb89d0e65a80e
This is not needed an a upstream patch, checkpatch should have told you :(
> Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org> > Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org> > --- > drivers/pwm/core.c | 26 ++++++++++++++++++++ > drivers/pwm/sysfs.c | 50 ++++++++++++++++++++++++++++++++++++++
You forgot a Documentation/ABI/ update for your new sysfs file :(
thanks,
greg k-h
| |