Messages in this thread | | | Date | Fri, 17 Sep 2021 21:32:46 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH v2] mtd: rawnand: xway: No hardcoded ECC engine, use device tree setting |
| |
Hi Jan,
jan@3e8.eu wrote on Fri, 17 Sep 2021 19:45:33 +0200:
> Hi Miquèl, > > > I am not sure to understand your message as answer to this thread. > > There are two problems here: > > 1/ The DT values not being taken into account > > This is the issue I'm referring to. > > > 1/ Has already been fixed (at least that is what I think) > > This is not fixed in kernel 5.10. And unless I am missing something > there also doesn't seem be a fix in more recent kernels. > > I am aware of commit 33d974e76e21 ("mtd: rawnand: xway: Do not force a > particular software ECC engine"), but that only fixes the ECC > algorithm. The ECC engine type is still hard-coded in xway_attach_chip.
Yes this was my understanding, that only software ECC engine was supported. The mainline driver shows absolutely no signs of hardware ECC engine support.
Perhaps however you mean that on-die ECC engine are not supported anymore because of the engine_type being set in attach_chip()? If yes then indeed there is something to do, perhaps checking if an engine has been already set is enough? You can try something like:
if (engine_type == unknown) engine_type = soft; Thanks, Miquèl
| |