lkml.org 
[lkml]   [2021]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/2] PCI: uniphier: Fix INTx masking/unmasking
On Thu, 16 Sep 2021 12:30:52 +0100,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com> wrote:
>
> Gentle ping, are there any comments about this series?
>
> Thank you,
>
> On 2021/08/30 11:22, Kunihiko Hayashi wrote:
> > This series includes some fixes to INTx masking/unmasking for UniPhier PCIe
> > host controller driver.
> >
> > - Remove unnecessary bit clears to INTX mask field
> > - Remove unnecessary irq_ack() function because write access to status field
> > doesn't work
> > - Add lock into callback functions to avoid race condition
> >
> > Kunihiko Hayashi (2):
> > PCI: uniphier: Fix INTx mask/unmask bit operation and remove ack
> > function
> > PCI: uniphier: Serialize INTx masking/unmasking
> >
> > drivers/pci/controller/dwc/pcie-uniphier.c | 26 ++++++++++----------------
> > 1 file changed, 10 insertions(+), 16 deletions(-)
> >

Patches look OK, although I would personally squash them into a single
one (INTx masking never really worked before that). FWIW:

Acked-by: Marc Zyngier <maz@kernel.org>

N,

--
Without deviation from the norm, progress is not possible.

\
 
 \ /
  Last update: 2021-09-17 15:55    [W:0.089 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site