Messages in this thread | | | Date | Thu, 16 Sep 2021 08:35:16 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has() |
| |
On Wed, Sep 15, 2021 at 07:18:34PM +0200, Christophe Leroy wrote: > Could you please provide more explicit explanation why inlining such an > helper is considered as bad practice and messy ?
Because now we get architectures to all subly differ. Look at the mess for ioremap and the ioremap* variant.
The only good reason to allow for inlines if if they are used in a hot path. Which cc_platform_has is not, especially not on powerpc.
| |