lkml.org 
[lkml]   [2021]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] PCI: endpoint: Use sysfs_emit() in "show" functions
From
Date
Gentle ping, are there any comments?

Thank you,

On 2021/09/01 14:09, Kunihiko Hayashi wrote:
> Convert sprintf() in sysfs "show" functions to sysfs_emit() in order to
> check for buffer overruns in sysfs outputs.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
> ---
> Changes since v1:
> - Add Reviewed-by line
>
> ---
> drivers/pci/endpoint/functions/pci-epf-ntb.c | 4 ++--
> drivers/pci/endpoint/pci-ep-cfs.c | 13 ++++++-------
> 2 files changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-ntb.c b/drivers/pci/endpoint/functions/pci-epf-ntb.c
> index 8b47561..99266f05 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-ntb.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-ntb.c
> @@ -1937,7 +1937,7 @@ static ssize_t epf_ntb_##_name##_show(struct config_item *item, \
> struct config_group *group = to_config_group(item); \
> struct epf_ntb *ntb = to_epf_ntb(group); \
> \
> - return sprintf(page, "%d\n", ntb->_name); \
> + return sysfs_emit(page, "%d\n", ntb->_name); \
> }
>
> #define EPF_NTB_W(_name) \
> @@ -1968,7 +1968,7 @@ static ssize_t epf_ntb_##_name##_show(struct config_item *item, \
> \
> sscanf(#_name, "mw%d", &win_no); \
> \
> - return sprintf(page, "%lld\n", ntb->mws_size[win_no - 1]); \
> + return sysfs_emit(page, "%lld\n", ntb->mws_size[win_no - 1]); \
> }
>
> #define EPF_NTB_MW_W(_name) \
> diff --git a/drivers/pci/endpoint/pci-ep-cfs.c b/drivers/pci/endpoint/pci-ep-cfs.c
> index 9999118..5a0394a 100644
> --- a/drivers/pci/endpoint/pci-ep-cfs.c
> +++ b/drivers/pci/endpoint/pci-ep-cfs.c
> @@ -198,8 +198,7 @@ static ssize_t pci_epc_start_store(struct config_item *item, const char *page,
>
> static ssize_t pci_epc_start_show(struct config_item *item, char *page)
> {
> - return sprintf(page, "%d\n",
> - to_pci_epc_group(item)->start);
> + return sysfs_emit(page, "%d\n", to_pci_epc_group(item)->start);
> }
>
> CONFIGFS_ATTR(pci_epc_, start);
> @@ -321,7 +320,7 @@ static ssize_t pci_epf_##_name##_show(struct config_item *item, char *page) \
> struct pci_epf *epf = to_pci_epf_group(item)->epf; \
> if (WARN_ON_ONCE(!epf->header)) \
> return -EINVAL; \
> - return sprintf(page, "0x%04x\n", epf->header->_name); \
> + return sysfs_emit(page, "0x%04x\n", epf->header->_name); \
> }
>
> #define PCI_EPF_HEADER_W_u32(_name) \
> @@ -390,8 +389,8 @@ static ssize_t pci_epf_msi_interrupts_store(struct config_item *item,
> static ssize_t pci_epf_msi_interrupts_show(struct config_item *item,
> char *page)
> {
> - return sprintf(page, "%d\n",
> - to_pci_epf_group(item)->epf->msi_interrupts);
> + return sysfs_emit(page, "%d\n",
> + to_pci_epf_group(item)->epf->msi_interrupts);
> }
>
> static ssize_t pci_epf_msix_interrupts_store(struct config_item *item,
> @@ -412,8 +411,8 @@ static ssize_t pci_epf_msix_interrupts_store(struct config_item *item,
> static ssize_t pci_epf_msix_interrupts_show(struct config_item *item,
> char *page)
> {
> - return sprintf(page, "%d\n",
> - to_pci_epf_group(item)->epf->msix_interrupts);
> + return sysfs_emit(page, "%d\n",
> + to_pci_epf_group(item)->epf->msix_interrupts);
> }
>
> PCI_EPF_HEADER_R(vendorid)
>

--
---
Best Regards
Kunihiko Hayashi

\
 
 \ /
  Last update: 2021-09-16 13:31    [W:0.134 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site